Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Last revision Both sides next revision
floating-point-equality [2017/11/21 12:27]
awf
floating-point-equality [2018/09/05 14:53]
awf [But my case is more subtle than that]
Line 77: Line 77:
 } }
 </​code>​ </​code>​
 +
 +It's a good idea then to write a blog post about the issue, because Toby Sharp might comment (see below) and point out that there is a much better choice:
 +
 +> "... since we need some kind of test for x=0 anyway, I don't see why we shouldn'​t take the opportunity to improve accuracy in this vicinity. And yes, it only costs 2 multiplies which is less than using the sin in those cases. So we are improving both performance and accuracy in the range (0, threshold). threshold is chosen to be the largest value such that the quadratic approximation is as good as the direct evaluation."​
 +
 +<code C++>
 +float sinc(float x) { 
 +  // Toby's threshold, determined through binary search as the best value for minimizing absolute error
 +  if (std::​abs(x) < 0.0406015441f)
 +      return 1.0f - (x * x) * (1.0f / 6.0f);
 +  else
 +      return std::sin(x) / x;
 +
 +</​code>​
 +
  
 === And templates? === === And templates? ===